Skip to content

CW2-37 404 Page #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jul 25, 2024
Merged

CW2-37 404 Page #20

merged 27 commits into from
Jul 25, 2024

Conversation

QuadAces
Copy link
Contributor

@QuadAces QuadAces commented Jul 3, 2024

Why the changes are required?

To add a 404 page

Changes

  • added 404.tsx
  • added header, footer, and navbar to the page
  • added framer transition as a small easter egg (or corny joke as per the spec)

Screenshots

Screenshot 2024-07-04 at 1 58 21 am
Screenshot 2024-07-04 at 1 58 39 am

Comments

Nothing much. Once the website is live, I believe should migrate to next.js 14 if we are to continue developing the website. We are currently using the /pages directory as well as the "outdated 404" method - and also can't take advantage of the website's endpoints (which I assume is why we are creating a separate backend for some reason). This is just something I'd like to bring to attention, nothing but isn't urgent at any capacity however.

Copy link
Contributor

@derekxu04 derekxu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, added a couple of comments, but overall should be almost ready to merge!

</p>
<motion.div className="opacity-0" whileHover={{ opacity: 1 }} transition={{duration: 0.2}}>
<p className="text-2xl pt-10">
While we may have found some tomfoolery, we haven't found your page :'(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha I like the animation

I'm wondering if you can do this just with tailwind, don't have to use framer, could potentially be easier and more inline with the rest of the css

Also: I think it would be cool to have some CS themed error messages, maybe even alternate between a few random ones, could be a fun easter egg (e.g. just asking chatgpt lol:

  • Oops! This page must have been garbage collected.
  • Looks like this page hit a segmentation fault.
  • 404 Error: The page you’re looking for has been deprecated.
    etc.

@QuadAces QuadAces requested a review from derekxu04 July 25, 2024 04:31
@derekxu04 derekxu04 merged commit 6469bae into master Jul 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants