-
Notifications
You must be signed in to change notification settings - Fork 0
CW2-37 404 Page #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CW2-37 404 Page #20
Conversation
…exactly the same component at ./resources
…page in index.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, added a couple of comments, but overall should be almost ready to merge!
frontend/src/pages/404.tsx
Outdated
</p> | ||
<motion.div className="opacity-0" whileHover={{ opacity: 1 }} transition={{duration: 0.2}}> | ||
<p className="text-2xl pt-10"> | ||
While we may have found some tomfoolery, we haven't found your page :'( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha I like the animation
I'm wondering if you can do this just with tailwind, don't have to use framer, could potentially be easier and more inline with the rest of the css
Also: I think it would be cool to have some CS themed error messages, maybe even alternate between a few random ones, could be a fun easter egg (e.g. just asking chatgpt lol:
- Oops! This page must have been garbage collected.
- Looks like this page hit a segmentation fault.
- 404 Error: The page you’re looking for has been deprecated.
etc.
Why the changes are required?
To add a 404 page
Changes
Screenshots
Comments
Nothing much. Once the website is live, I believe should migrate to next.js 14 if we are to continue developing the website. We are currently using the /pages directory as well as the "outdated 404" method - and also can't take advantage of the website's endpoints (which I assume is why we are creating a separate backend for some reason). This is just something I'd like to bring to attention, nothing but isn't urgent at any capacity however.